Add some handling for tag edge cases #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly handle updating tags if the page doesn't already have them - JSON-ify tags so Confluence can properly consume the data Fixes iamjackg#117
nate-woythaler
commented
Nov 13, 2023
| @@ -243,7 +246,8 @@ def add_labels(self, page, labels): | |||
| # return self.api.content(page.id).post( | |||
| return self._post( | |||
| f"content/{page.id}/label", | |||
| data=[{"name": label, "type": "global"} for label in labels], | |||
| data=json.dumps([{"name": label, "type": "global"} for label in labels]), | |||
There was a problem hiding this comment.
I'm not sure if this is the correct approach, but our Confluence instance was giving me back HTTP 415s when submitting binary data via the **kwargs expansion on line 68
415 Client Error: Unsupported Media Type for url: https://${CONFLUENCE_URL}/rest/api/content/515736017/label - b''
|
Chaining the `get` calls would mean a messy amount of Mocks. Just use a
single `get` call and if it's empty return a dummy struct for sanity's
sake.
Also `get('name')` on the returned struct since we run into issues with
Mocking without it.
Fixes iamjackg#117
nate-woythaler
commented
Nov 14, 2023
nate-woythaler
force-pushed
the
master
branch
from
5af462f
to
7c0f1ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117